-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alcohol v2 electric boogaloo #1662
alcohol v2 electric boogaloo #1662
Conversation
RSI Diff Bot; head commit 5f858c4 merging into 2bd7120 Resources/Textures/_NF/Objects/Consumable/Drinks/beesknees.rsi
Resources/Textures/_NF/Objects/Consumable/Drinks/ginandsonic.rsi
Resources/Textures/_NF/Objects/Consumable/Drinks/goldencat.rsi
Resources/Textures/_NF/Objects/Consumable/Drinks/pineappleblast.rsi
Resources/Textures/_NF/Objects/Consumable/Drinks/torpedojuice.rsi
|
…p/frontier-station-14 into enhanced_alcoholism_v2 moar drink
…-station-14 into enhanced_alcoholism_v2
dont have much time right now, cant say when im able to continue, gonna open it for your review |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
fixing errors
more fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, so the stuff works, but imo drink sprites are way too big in comparison with other glass sprites and unfortunately they aren't scalable on yml side, so they need to be scaled down in graphical editor. I don't think that I'm interested in doing it, unless someone is willing to take this burden I'll close this PR soon(ish).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the sprites, good to go. Would like someone else to check it before merging though.
Giving it a look. |
Touching up a few of the sprites, will ask for your thoughts when I'm done with them. Don't think it's anything huge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go. Enlarged the base on the gin and sonic, flipped the metal bit on top (difficult to read with so few pixels, looks more like an opening), moved the straw over on the bee's knees, cleaned up the lines on the chest in the golden cat, and added some more fill states to most drinks.
Minor rewrites to descriptions, fixed up the fast flavour reference. Looks good on my end. @ErhardSteinhauer, a sanity check would be appreciated when you can.
Changes work fine. |
About the PR
Five more drinks: Gin and Sonic, Golden Cat, Pineapple Blast, Torpedo Juice and Bees Knees.
Why / Balance
Fun
How to test
Media
New drinks - first five on the left side of the table
Breaking changes
None (I think)
Changelog
🆑 ray-boop